bpf: Don't redirect packets with invalid pkt_len
authorZhengchao Shao <shaozhengchao@huawei.com>
Fri, 15 Jul 2022 11:55:59 +0000 (19:55 +0800)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 2 Sep 2022 13:54:53 +0000 (14:54 +0100)
commitf8555e4649f1c717dbdbf1a8db1e1550f9724896
treefeb39fabfb450c4cfe3295e8262ba02ea0968aea
parentd282036b3e75d2627106f25cf664eead13d63cb9
bpf: Don't redirect packets with invalid pkt_len

commit fd1894224407c484f652ad456e1ce423e89bb3eb upstream.

Syzbot found an issue [1]: fq_codel_drop() try to drop a flow whitout any
skbs, that is, the flow->head is null.
The root cause, as the [2] says, is because that bpf_prog_test_run_skb()
run a bpf prog which redirects empty skbs.
So we should determine whether the length of the packet modified by bpf
prog or others like bpf_prog_test is valid before forwarding it directly.

LINK: [1] https://syzkaller.appspot.com/bug?id=0b84da80c2917757915afa89f7738a9d16ec96c5
LINK: [2] https://www.spinics.net/lists/netdev/msg777503.html

Reported-by: syzbot+7a12909485b94426aceb@syzkaller.appspotmail.com
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/r/20220715115559.139691-1-shaozhengchao@huawei.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name bpf-don-t-redirect-packets-with-invalid-pkt_len.patch
include/linux/skbuff.h
net/bpf/test_run.c
net/core/dev.c